Automatically upgrade GitHub Action dependencies with Dependabot#274
Automatically upgrade GitHub Action dependencies with Dependabot#274
Conversation
|
Preview using JupyterLite: appsharing.space |
|
Docs preview: appsharing.space |
|
Integration tests report: appsharing.space |
brichet
left a comment
There was a problem hiding this comment.
LGTM, thanks @mfisher87
|
I forgot to mention that the lint test should have been fixed before merging, sorry. |
|
It is not mysterious 😀, the file added in this PR does not pass the check lint. |
You're right, it just looked that way, being new to the project. When the step failed with 3 warnings, I assumed linting was set to fail on warnings, and ignored the list of filenames at the end of the log because there was no context telling me what that list of filenames meant! So I focused on the warnings instead of the real problem. The warnings have been there for at least 4 months. Also, running lint locally passes even if errors are found and files are updated. So I got very confused :) Thanks for your patience!!! EDIT: Let's discuss in #281 |
We have some outdated versions called out in GitHub actions (here, scroll down to see "Annotations"), some scheduled for deprecation.