Skip to content

Automatically upgrade GitHub Action dependencies with Dependabot#274

Merged
mfisher87 merged 1 commit intomainfrom
autoupgrade-github-actions
Jan 2, 2025
Merged

Automatically upgrade GitHub Action dependencies with Dependabot#274
mfisher87 merged 1 commit intomainfrom
autoupgrade-github-actions

Conversation

@mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Dec 26, 2024

We have some outdated versions called out in GitHub actions (here, scroll down to see "Annotations"), some scheduled for deprecation.

@mfisher87 mfisher87 added the maintenance Fixing lint errors, changing project metadata, changing tooling, changing dependencies, etc. label Dec 26, 2024
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch geojupyter/jupytergis/autoupgrade-github-actions

@github-actions
Copy link
Contributor

Preview using JupyterLite: appsharing.space

@github-actions
Copy link
Contributor

Docs preview: appsharing.space

@github-actions
Copy link
Contributor

Integration tests report: appsharing.space

Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mfisher87

@mfisher87 mfisher87 merged commit d5023a2 into main Jan 2, 2025
12 of 13 checks passed
@mfisher87 mfisher87 deleted the autoupgrade-github-actions branch January 2, 2025 15:54
@brichet
Copy link
Collaborator

brichet commented Jan 2, 2025

I forgot to mention that the lint test should have been fixed before merging, sorry.
@mfisher87 can you open a PR to fix it ?

@mfisher87
Copy link
Member Author

@brichet These are the same lint errors that mysteriously started showing up in #275. I addressed the errors there as requested, but now linting is failing without errors and I'm confused :) Any help or ideas would be appreciated!

@brichet
Copy link
Collaborator

brichet commented Jan 2, 2025

It is not mysterious 😀, the file added in this PR does not pass the check lint.
Here it is: https://github.com/geojupyter/jupytergis/actions/runs/12506371948/job/34891217855#step:4:55
Try running jlpm lint locally, that should update the file.

@mfisher87
Copy link
Member Author

mfisher87 commented Jan 2, 2025

It is not mysterious 😀

You're right, it just looked that way, being new to the project. When the step failed with 3 warnings, I assumed linting was set to fail on warnings, and ignored the list of filenames at the end of the log because there was no context telling me what that list of filenames meant! So I focused on the warnings instead of the real problem. The warnings have been there for at least 4 months. Also, running lint locally passes even if errors are found and files are updated. So I got very confused :) Thanks for your patience!!!

EDIT: Let's discuss in #281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Fixing lint errors, changing project metadata, changing tooling, changing dependencies, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants